feat(lambda): link for serverlessland and fixes for serverless land #6687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vandita2020
force-pushed
the
bug_bash_changes
branch
from
36dc419 to
1010f9c
Compare
packages/core/src/awsService/appBuilder/serverlessLand/webViewManager.ts
Outdated
Show resolved
Hide resolved
Vandita2020
force-pushed
the
bug_bash_changes
branch
from
1010f9c to
56bc627
Compare
Vandita2020
changed the title
jpinkney-aws
reviewed
Mar 3, 2025
| getLogger().warn('README.md file not found in the project directory') | ||
| return | ||
| } | ||
| await new Promise((resolve) => setTimeout(resolve, 2000)) |
Contributor
There was a problem hiding this comment.
why do we need a sleep? We also have a sleep util
Contributor
Author
There was a problem hiding this comment.
We need sleep to give time for README preview to load, so that it opens correctly. I have used sleep util now. Thanks!
Contributor
There was a problem hiding this comment.
? Use waitUntil to check for the file to exist. sleep() is a poor user experience, and also fragile (some systems could be very slow temporarily, for various reasons).
roger-zhangg
approved these changes
Mar 3, 2025
Member
roger-zhangg
left a comment
roger-zhangg
left a comment
There was a problem hiding this comment.
would be great if 'Open in Serverless Land' is imported, other LGTM
Vandita2020
force-pushed
the
bug_bash_changes
branch
from
865094f to
0f856fe
Compare
justinmk3
reviewed
Mar 4, 2025
packages/core/src/awsService/appBuilder/serverlessLand/metadataManager.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Mar 4, 2025
packages/core/src/awsService/appBuilder/serverlessLand/wizard.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Mar 4, 2025
Vandita2020
force-pushed
the
bug_bash_changes
branch
2 times, most recently
from
6f02177 to
0b04764
Compare
Vandita2020
force-pushed
the
bug_bash_changes
branch
from
0b04764 to
f63ee4f
Compare
justinmk3
reviewed
Mar 4, 2025
Comment on lines
+74
to
+78
| target: path.join( | ||
| '../../node_modules/aws-core-vscode', | ||
| 'src', | ||
| 'awsService', | ||
| 'appBuilder', |
Contributor
There was a problem hiding this comment.
join() isn't needed here either. I see that you are following the existing pattern of this file, but this file really should be updated.
justinmk3
approved these changes
Mar 4, 2025
Vandita2020
added a commit
to Vandita2020/aws-toolkit-vscode
that referenced
this pull request
Mar 5, 2025
## Problem This PR adds the functionality to open pattern in serverless-land website. It addresses an issue with the `metadata.json` file path for the extension by specifying the path after the build step in the `copyFile.ts` file. ## Solution Changes: 1. Removed the webview functionality and instead open the browser to preview the patterns. 2. Removed the Github button. 3. Added a link at the bottom of pattern quick pick to explore the [serverless land website](https://serverlessland.com/patterns?services=lambda). 4. Ensured the proper path for the metadata file is accessible and it gets executed properly after the build. 5. Added another entry point at the AWS Explorer high-level, accessible when clicking the three-dot menu.
nkomonen-amazon
pushed a commit
to nkomonen-amazon/aws-toolkit-vscode
that referenced
this pull request
Mar 5, 2025
## Problem This PR adds the functionality to open pattern in serverless-land website. It addresses an issue with the `metadata.json` file path for the extension by specifying the path after the build step in the `copyFile.ts` file. ## Solution Changes: 1. Removed the webview functionality and instead open the browser to preview the patterns. 2. Removed the Github button. 3. Added a link at the bottom of pattern quick pick to explore the [serverless land website](https://serverlessland.com/patterns?services=lambda). 4. Ensured the proper path for the metadata file is accessible and it gets executed properly after the build. 5. Added another entry point at the AWS Explorer high-level, accessible when clicking the three-dot menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the functionality to open pattern in serverless-land website. It addresses an issue with the
metadata.jsonfile path for the extension by specifying the path after the build step in thecopyFile.tsfile.Solution
Changes:
feature/xbranches will not be squash-merged at release time.